Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spokeo mirror sites #2086

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Add Spokeo mirror sites #2086

merged 1 commit into from
Jan 26, 2024

Conversation

brianhall
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/0/1206384138432660/f
Tech Design URL:
CC:

Description:

Adds mirror sites to the PIR JSON files. So far we only have

Steps to test this PR:

  1. Clear your PIR database
  2. Start PIR, enter your info and do a search.
  3. You should (at the very least) see the total number of brokers searched increment to 33 (currently 29 + 4 mirror sites).

Screenshot 2024-01-18 at 11 59 56 AM

Screenshot 2024-01-18 at 12 13 41 PM


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@brianhall brianhall marked this pull request as ready for review January 18, 2024 21:41
Copy link
Collaborator

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianhall brianhall merged commit da64234 into main Jan 26, 2024
14 checks passed
@brianhall brianhall deleted the bhall/add-spokeo-mirror-sites branch January 26, 2024 19:18
samsymons added a commit that referenced this pull request Jan 30, 2024
* main:
  Restore VPN pixels in main browser (#2129)
  Bump BSK to 103.0.2 (#2126)
  Fix `site:` queries escaping with iOS 17 SDK (#640) (#2130)
  Add January 2024 brokers (part 2) (#2125)
  lastSentDate + web breakage report improvements (#2041)
  Remove VPN metadata admin check (#2127)
  Add Spokeo mirror sites (#2086)
  appcastManager: Retain release notes for all versions (#2123)
  Don't report CancellationError from BookmarksFaviconsFetcher (#2120)
  Sabrina/revert cards experiment (#2119)
  Bump version to 1.72.0 (113)
  Update embedded files
  Release Branch: VPN fixes (#2113)
  Adds info about whether the login items are actually running (#2122)
  Remove connection status awaiter. (#2121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants